hjwdzh / QuadriFlow

QuadriFlow: A Scalable and Robust Method for Quadrangulation
http://stanford.edu/~jingweih/papers/quadriflow/
Other
660 stars 76 forks source link

Stability fixes for the preserve sharp feature #40

Closed DarkDefender closed 5 years ago

DarkDefender commented 5 years ago

I have fixed some stability issues I ran into when using the "preserve sharp" feature.

Perhaps this isn't the way to go, but I couldn't really figure out how to fix these crashes in an other way.

hjwdzh commented 5 years ago

Thanks for this edits. In the original formulation, it is guaranteed that the flow will always give results. However, sharp flag tries to fix some edge as constants instead of variables, which make the system possible to derive no solution. Additionally, sharp flag is experimental and not always work. But I guess it is a good intermediate step to avoid crash. Thanks.