search

hjweide / pyastar2d

A very simple A* implementation in C++ callable from Python for pathfinding on a two-dimensional grid.
MIT License
150 stars 57 forks source link

Dynamic strating point allocation & equi-distance path from walls #2

Closed gajena closed 6 years ago

hjweide commented 6 years ago

Thanks for your contribution! I've been thinking how to include it such that it's most useful. Your tools are great for visualization/interaction, while the idea behind the main repository is to be a minimal library with basic usage examples. Perhaps you should continue your visualization features in your original fork, or perhaps create an entire new project that includes this one as a submodule. That way your feature would be the highlight of the project, rather than a side feature. What do you think?

PS. When committing Python code, please make sure your code follows PEP8. This will make the life of the person reviewing your code much easier :)

gajena commented 6 years ago

Thanks for your consideration.I was also thinking about develope a project including your code as module .RegardsGajendra NagarJunior Student, Department of Aerospace Engineering IIT KanpurOn 27-Feb-2018 7:47 AM, Hendrik Weideman notifications@github.com wrote:Thanks for your contribution! I've been thinking how to include it such that it's most useful. Your tools are great for visualization/interaction, while the idea behind the main repository is to be a minimal library with basic usage examples. Perhaps you should continue your visualization features in your original fork, or perhaps create an entire new project that includes this one as a submodule. That way your feature would be the highlight of the project, rather than a side feature. What do you think? PS. When committing Python code, please make sure your code follows PEP8. This will make the life of the person reviewing your code much easier :)

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

hjweide commented 6 years ago

Awesome, are you familiar with setting up submodules with git? It's pretty simple, take a look at how it's done in PyTorch, for example: https://github.com/pytorch/pytorch/blob/master/.gitmodules

Alternatively, you can just continue your fork, making it clear in the ReadMe that your project focuses more on visualization/interactivity and as a result has diverged from the main repository.