search

hjweide / pyastar2d

A very simple A* implementation in C++ callable from Python for pathfinding on a two-dimensional grid.
MIT License
150 stars 57 forks source link

Fix travis #32

Closed hjweide closed 2 years ago

peterchenadded commented 2 years ago

Thanks @hjweide

I didn't see any issues with python 3.7 and i could see the workflows still build the 3.7 wheel files.

Can you try below in travis.yml

before_install:
  - pip install -U pip
  - pip install numpy

This should fix up the numpy error, which i think i saw before when i was trying to build it

cheers,

peterchenadded commented 2 years ago

I think update the setup.py back to python 3.6 or 3.7 as i was able to build it on my windows without any issues and each of the github workflows worked on 3.7 as well.

The travis.yml can stay as python 3.8.

hjweide commented 2 years ago

I think update the setup.py back to python 3.6 or 3.7 as i was able to build it on my windows without any issues and each of the github workflows worked on 3.7 as well.

The travis.yml can stay as python 3.8.

Sounds good, let me try this

peterchenadded commented 2 years ago

Also can you put back below line

image

Seems without it the windows and mac builds will fail with below error

image

hjweide commented 2 years ago

Also can you put back below line

I just ran into that issue. I added it to the workflow files -- seems to be working across all three platforms now.

Do you want to try one of these?

https://test.pypi.org/project/pyastar2d/#files

hjweide commented 2 years ago

Published the wheels at: https://pypi.org/project/pyastar2d/#files

I'll take a look at these tomorrow. In the meantime, please let me know if you spot anything wrong with them. Thanks for your help with this!

peterchenadded commented 2 years ago

Awesome, looks good.

I tested for windows 3.7 , macos3.8 and Linux 3.7 without issues.

hjweide commented 2 years ago

Great! Thanks for letting me know.

On Mon, Apr 25, 2022 at 23:15 peterchenadded @.***> wrote:

Awesome, looks good.

I tested for windows 3.7 , macos3.8 and Linux 3.7 without issues.

— Reply to this email directly, view it on GitHub https://github.com/hjweide/pyastar2d/pull/32#issuecomment-1109257985, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSN6EG5ZDP5AQO7VNM6H7LVG5NWVANCNFSM5UKID42A . You are receiving this because you modified the open/close state.Message ID: @.***>

peterchenadded commented 2 years ago

I did notice the tar.gz was no longer published. If you still need that you can update below at the end of the Linux workflow

      run: |
        python setup.py sdist
        #python -m twine upload --repository testpypi dist/*-manylinux*.whl dist/*.tar.gz --verbose --skip-existing
        python -m twine upload dist/*-manylinux*.whl dist/*.tar.gz --verbose --skip-existing

Note the below two additions

  1. Python command to generate the tar.gz
  2. Twine to include dist/*.tar.gz for upload
hjweide commented 2 years ago

Good catch. Yes, it would be good to publish a source distribution. I’ll make these changes tonight.

On Tue, Apr 26, 2022 at 07:32 peterchenadded @.***> wrote:

I did notice the tar.gz was no longer published. If you still need that you can update below at the end of the Linux workflow

  run: |
    python setup.py sdist
    #python -m twine upload --repository testpypi dist/*-manylinux*.whl dist/*.tar.gz --verbose --skip-existing
    python -m twine upload dist/*-manylinux*.whl dist/*.tar.gz --verbose --skip-existing

Note the below two additions

  1. Python command to generate the tar.gz
  2. Twine to include dist/*.tar.gz for upload

— Reply to this email directly, view it on GitHub https://github.com/hjweide/pyastar2d/pull/32#issuecomment-1109683243, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSN6EHG3IVEOTNTINHCMBTVG7H3XANCNFSM5UKID42A . You are receiving this because you modified the open/close state.Message ID: @.***>