hjwp / Book-TDD-Web-Dev-Python

Book - TDD web dev with Python
https://www.obeythetestinggoat.com
Other
484 stars 175 forks source link

Review of chapter 11 #229

Closed Enforcer closed 4 months ago

Enforcer commented 5 months ago

All in all, I am not very fond of the current shape of this chapter.

The summary is great and the choice of technologies is the best I can imagine.

However, I got lost several times while reading through the chapter. There are too many open loops. For example, SSH is mentioned but then we jump into all other technologies without seeing what SSH is and how it will play with the rest.

mentioning of too many technologies (e.g. Puppet/Chef - IMHO not necessary in 2024).

I think (my opinion) the chapter needs reorganizing so that readers can more quickly see a given piece of tech in action. I'd cut some content.

If you like some more specific suggestions, I can spend more time and provide them.

Also, it's mentioned that the server will be provisioned manually without automation, but then we get ansible infra/ansible-provision.yaml. I must say I'm not following when provisioning starts and where it ends. In my book (figuratively speaking), installing docker falls under the definition of provisioning (which was meant NOT to be automated) while the remaining steps, like exporting and reimporting docker image are something different (deployment?).

I also added several more comments.