search

hk-modding / api

Hollow Knight Modding API
MIT License
226 stars 62 forks source link

IMod instead of Mod #136

Closed Ruttie2006 closed 2 years ago

Ruttie2006 commented 2 years ago

ModLoader.cs has the following: https://github.com/hk-modding/api/blob/21ba19b0e70d1a0b703eea9cb874f22a6d35cc7d/Assembly-CSharp/ModLoader.cs#L169 Why does this check for typeof(Mod) instead of seeing if it has the IMod interface? This way, instead of having custom Mod classes that implement IMod, every custom mod class has to derive from Mod, which is quite limiting imo.

fifty-six commented 2 years ago

IMod is largely just legacy, we rely on it being Mod in order to add members when wanted as well as for other implementation details.