search

hkdb / app

A cross-platform package management assistant with super powers!
https://hkdb.github.io/app/
Apache License 2.0
55 stars 2 forks source link

Enable: fix package manager name #6

Closed RichardFevrier closed 1 month ago

RichardFevrier commented 1 month ago

Using app enable packageManagerName was failing cause the code was checking the system package manager and not the one provided by packageManagerName. Fixed.

hkdb commented 1 month ago

This is super funny... one of my friends who's a user of this literally just asked me about this today. He tried app enable flatpak and it didn't work and I told him, it's supposed to be app -m flatpak enable and then proceeded to say, “but hum... maybe I should change it so that both app -m flatpak enable and app enable flatpak will work. 😂️ Thanks so much for this!

Btw, I am pretty slammed this week but will get to reviewing all the pull requests soon...

RichardFevrier commented 1 month ago

The behavior you have coded makes totally sence, my bad! I should have read more carefully the helper usage part. 😬

We are too formatted with the english syntax where the action takes place before the subject like here app action subject => app enable flatpak.

But honestly your code works well for me, I'll close this.