hkirat / notification-logger

Desktop notification for your console Logs
http://hkirat.github.io/notification-logger
1.02k stars 57 forks source link

Support Chrome for Android #5

Open simevidas opened 7 years ago

simevidas commented 7 years ago

I’ve tested your demo in browsers on Android; it works in Firefox, but not in Chrome. Could you confirm?

hkirat commented 7 years ago

Works fine on Desktop. Never tried on Android. As for ios it is not working on Safari.

simevidas commented 7 years ago

Having this feature on mobile would be quite useful, I think, because unlike desktop, you can’t just open DevTools on the mobile device. Instead, you’d have to connect the device via USB and activate remote debugging. You library seems like a handy alternative to that.

So, it’s definitely worth making this work on mobile as well. Note that testing on real mobile devices has become an integral part of web development.

hkirat commented 7 years ago

Thanks for the suggestion @simevidas I totally agree that testing on mobile devices is integral these days. I've never tried remote debugging, but I will after this. Could you once check with your chrome whether or not the application was provided permission to provide Desktop Notification. Did a popup asking for permission appear in chrome?

simevidas commented 7 years ago

Yes, I got the permission dialog and enabled notifications.

I just tested via remote debugging and got this error when trying your demo: capture

hkirat commented 7 years ago

Thanks @simevidas . I'll look into it

leocabeza commented 7 years ago

Notifications in Chrome Mobile are a known issue, maybe this helps, but works only in https: http://stackoverflow.com/questions/31512504/html5-notification-not-working-in-mobile-chrome