hkirk / java-html2image

Automatically exported from code.google.com/p/java-html2image
136 stars 68 forks source link

Version 3.0 #32

Open pizzi80 opened 2 months ago

pizzi80 commented 2 months ago

Hi, this is my contribution to the project 💣 😄

hkirk commented 2 months ago

Nice job will try to look at this weekend, but seems like a very meticolous PR

pizzi80 commented 2 months ago

Thanks! I tried my best 😅

I'm writing you some more notes because when I did the PR(s) it was late and I was fighting with jitpack ... :angry:

At first I made a PR with HtmlUnit 4.x But after a second review I realized that it doesn't support many html/css "stuff", so I went back to 1.9.latest, which seems to work quite well although it's not perfect because it doesn't support the "latest" css techniques, "flex" for example...

JPG rendering is always so-so in java, at the moment the quality seems decent, I should try with TwelveMonkeys to see if it improves, but in my opinion it's not worth putting it as a dependency because if you want you can always add it to the project as you like (eg. system library, Tomcat lib, webapp lib, ... ) and it's transparent for the developer ...

Last but not least, sorry for the changes to the "imports" but my ide is configured as required for some Jakarta EE Projects I contribute to and they are very serious about it... 😅