hklages / node-red-contrib-sonos-plus

A set of Node-RED nodes to control SONOS player in your local network.
MIT License
75 stars 14 forks source link

Support artistRadio #277

Closed danielvandenberg95 closed 2 months ago

danielvandenberg95 commented 5 months ago

Description

Support artistRadio, as supported in https://github.com/svrooij/node-sonos-ts/blob/de5e822a952666380a5acf81bc7ae1e0678abcfd/src/helpers/metadata-helper.ts#L258

What node/command (topic)/state (payload)

node: Universal command: group.queue.urispotify state: ehh, any?

In case of a bug: Are you able to reproduce the error

Not a bug

Versions and Infrastructure

what system: docker on linux node-red-contrib-sonos-plus version: 6.3.0 Node-RED version: 3.0.2 NodeJS version: I honestly don't know but don't think it matters....

Code to be adjusted:

https://github.com/hklages/node-red-contrib-sonos-plus/blob/20a12a76b3c368e83786e8bc39e74404134df49b/src/sonos-universal.js#L1798 Needs an extra line, spotify:artistRadio. Should then magically work?

hklages commented 5 months ago

... thanks for your precise information. I will try to implement it. It will take a few days as I have to rebuild my test environment.

best regards, Henning

On Sun, Feb 4, 2024 at 12:06 PM Daniël van den Berg < @.***> wrote:

Description

Support artistRadio, as supported in https://github.com/svrooij/node-sonos-ts/blob/de5e822a952666380a5acf81bc7ae1e0678abcfd/src/helpers/metadata-helper.ts#L258 What node/command (topic)/state (payload)

node: Universal command: group.queue.urispotify state: ehh, any? In case of a bug: Are you able to reproduce the error

Not a bug Versions and Infrastructure

what system: docker on linux node-red-contrib-sonos-plus version: 6.3.0 Node-RED version: 3.0.2 NodeJS version: I honestly don't know but don't think it matters.... Code to be adjusted:

https://github.com/hklages/node-red-contrib-sonos-plus/blob/20a12a76b3c368e83786e8bc39e74404134df49b/src/sonos-universal.js#L1798 Needs an extra line, spotify:artistRadio. Should then magically work?

— Reply to this email directly, view it on GitHub https://github.com/hklages/node-red-contrib-sonos-plus/issues/277, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDZCH7WXWVEWQALWHRBX7DYR5TURAVCNFSM6AAAAABCYYW6DSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTOMBTHA4DANI . You are receiving this because you were assigned.Message ID: @.***>

hklages commented 5 months ago

Hi, I added the line of code - please be so kind and test it. I dont have a spotify account.

svrooij commented 4 months ago

And I found out (which is missing from the docs), you cannot add artist radio to the queue, you'll need to set it with SetAVTransportURI

image

Or AVTransportService.SetAVTransportURI

hklages commented 4 months ago

@danielvandenberg95 : Would it be an option for you to do the following:

in the official SONOS app:

The radio shows up in My Sonos under playlists.

in sonos-plus:

If you have too many SpotifyArtistRadio and it is too boring to add them all, we can try to automate that with: in sonos plus:

Does that work for your?

danielvandenberg95 commented 4 months ago

Radio does not seem to be a playlist, nor appear in a playlist. When playing a radio station, my queue remains untouched.

Perhaps you could show me what you mean using screenshots?

hklages commented 4 months ago

Maybe I dont understand artistRadio. What artistRadio do you want to use? Is it something like "Eminem Radio" or "Tayloer Swift Radio" or something different?

Eminem 1Plus Eminem 2Plus Eminem 3plus

danielvandenberg95 commented 4 months ago

Screenshot_20240218-161231 It seems to be slightly different on my phone, it doesn't treat it as a playlist but as a station. I'll try to see if I can activate a station from my sonos...

Edit three seconds later: image How do I get the available stations...

image "mysonos.get.items:htmlData is not string :: Details: {"stack":"Error: htmlData is not string\n at decodeHtmlEntity (/data/node_modules/node-red-contrib-sonos-plus/src/Helper.js:42:13)\n at getUpnpClassEncoded (/data/node_modules/node-red-contrib-sonos-plus/src/Extensions.js:580:27)\n at /data/node_modules/node-red-contrib-sonos-plus/src/Commands.js:659:32\n at Array.map ()\n at getMySonos (/data/node_modules/node-red-contrib-sonos-plus/src/Commands.js:646:58)\n at processTicksAndRejections (node:internal/process/task_queues:96:5)\n at async Object.mysonosGetItems [as mysonos.get.items] (/data/node_modules/node-red-contrib-sonos-plus/src/sonos-manage-mysonos.js:393:21)","message":"htmlData is not string"}"

Ehh, not like that apparently....

Export itemsdoes not work either, same error.

hklages commented 4 months ago

Ok. First I have to fix another issue regarding the mysonos commands. Hopefully on Monday

Then we can continue.

On Sun, Feb 18, 2024, 16:13 Daniël van den Berg @.***> wrote:

Screenshot_20240218-161231.png (view on web) https://github.com/hklages/node-red-contrib-sonos-plus/assets/8654023/1481a197-5ca7-479e-94bd-bc0875f0552f Text incoming, editing this on my laptop...

— Reply to this email directly, view it on GitHub https://github.com/hklages/node-red-contrib-sonos-plus/issues/277#issuecomment-1951354645, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDZCH2KRHAIJ4U7M5QORFDYUILDBAVCNFSM6AAAAABCYYW6DSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGM2TINRUGU . You are receiving this because you were assigned.Message ID: @.***>

hklages commented 4 months ago

Hi, there is now a new release. Please install it and let's see what error messages shows up in your flow.

On Sun, Feb 18, 2024, 16:13 Daniël van den Berg @.***> wrote:

Screenshot_20240218-161231.png (view on web) https://github.com/hklages/node-red-contrib-sonos-plus/assets/8654023/1481a197-5ca7-479e-94bd-bc0875f0552f Text incoming, editing this on my laptop...

— Reply to this email directly, view it on GitHub https://github.com/hklages/node-red-contrib-sonos-plus/issues/277#issuecomment-1951354645, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDZCH2KRHAIJ4U7M5QORFDYUILDBAVCNFSM6AAAAABCYYW6DSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGM2TINRUGU . You are receiving this because you were assigned.Message ID: @.***>

hklages commented 2 months ago

Does not work - currently no solution available.