hkmoffat / cantera

Automatically exported from code.google.com/p/cantera
0 stars 0 forks source link

Improve Comments on OneD eval() function #108

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The comments in the OneD source files that describe the equations to be solved 
are not existing or (partially) wrong.
I created a patch file that states the equations to be solved. I hope you find 
it useful.

There is just one term in the energy equation which I didn't get, but 
apparently it is zero at all times anyway.

Original issue reported on code.google.com by thetruet...@googlemail.com on 24 Aug 2012 at 4:29

Attachments:

GoogleCodeExporter commented 9 years ago
Changes applied to OneD in r1822.

I'm not sure what "m_efctr" was supposed to be, but it's undocumented and 
unused. Removed in r1823.

I think the code in the "bvp" directory is an old version of the code that's 
now in OneD, so it's not really worth updating in general, and should probably 
be removed.

Original comment by yarmond on 29 Aug 2012 at 10:16

GoogleCodeExporter commented 9 years ago
Thanks a lot for the update!

Original comment by thetruet...@googlemail.com on 30 Aug 2012 at 7:36