build fails when using scons msi

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Update svn to latest version
2. run 'scons msi'

What is the expected output? What do you see instead?
I expected scons to build a .msi installer. Instead, the build phase exits with 
the following error:
KeyError: 'FRAMEWORKS':
  File "C:\Projects\cantera\SConstruct", line 1227:
    SConscript('build/samples/cxx/SConscript')
  File "C:\Python27\Scripts\..\Lib\site-packages\scons-2.1.0\SCons\Script\SConsc
ript.py", line 614:
    return method(*args, **kw)
  File "C:\Python27\Scripts\..\Lib\site-packages\scons-2.1.0\SCons\Script\SConsc
ript.py", line 551:
    return _SConscript(self.fs, *files, **subst_kw)
  File "C:\Python27\Scripts\..\Lib\site-packages\scons-2.1.0\SCons\Script\SConsc
ript.py", line 260:
    exec _file_ in call_stack[-1].globals
  File "C:\Projects\cantera\samples\cxx\SConscript", lin
e 44:
    localenv['tmpl_cantera_frameworks'] = repr(localenv['FRAMEWORKS'])
  File "C:\Python27\Scripts\..\Lib\site-packages\scons-2.1.0\SCons\Environment.p
y", line 409:
    return self._dict[key]

What version of the product are you using? On what operating system?
Trying to compile the latest svn version (r1902) under Windows 7 (32-bit), 
Python 2.7.2, MSVC 10.0 compiler, WiX Toolset 3.6, scons 2.1.0r5327

Please provide any additional information below.
Commenting line 44 in samples\cxx\SConscript and removing 
FRAMEWORKS=@tmpl_cantera_frameworks@ from samples\cxx\SConstruct.in 'fixes' the 
issue (but probably breaks the scripts under mac os x?)

On a related note, wouldn't it make sense to add an option in the cantera.conf 
to specify the WiX installation path? I figured out that I had to export this 
path manually to a 'wix' environment variable, but I think it would be more 
logical to be able to specify this in the configuration file.

Thanks!

Original issue reported on code.google.com by chdoi...@gmail.com on 29 Oct 2012 at 10:14

[GoogleCodeExporter]

Fixed in r1904.

The 'WIX' environment variable is automatically created by the WIX installer. 
I'm not sure why that didn't work for you. Perhaps you were using a command 
prompt that was open before you installed WiX, which would not have inherited 
the updated environment variables?

Original comment by yarmond on 30 Oct 2012 at 3:50

• Changed state: Fixed

[GoogleCodeExporter]

Thanks for fix.

The WIX environment variable is indeed automatically set when I open a new 
prompt. I indeed don't remember re-opening a prompt after installing WiX, so I 
guess you're right and the installer simply did not update the environment in 
prompts that were already running while installing.

Original comment by chdoi...@gmail.com on 31 Oct 2012 at 8:56