hkmoon / DockFX

A fully featured docking library for the JavaFX platform.
GNU Lesser General Public License v3.0
6 stars 19 forks source link

All dockable windows are tabs. Undocked create a window for further docking. #4

Open alexkoon opened 7 years ago

alexkoon commented 7 years ago

Every window is now a tab on content pane for a consistent look in dock panes. An undocked pane creates its own window where further windows can be docked. Allows an app to have multiple windows across monitors for example. Empty windows cleaned up.

Bug fix for isTabbed in DockNode - not uses the TabbedProperty value.

alexkoon commented 7 years ago

Hi - have you had a chance to look at this yet? Or any issues?

hkmoon commented 7 years ago

Hi @alexkoon

First of all, I am sorry for my laziness due to current projects. I could not take a look on your code. Today, I had a chance to do that actually.

However, many people are using https://github.com/ClearControl/DockFX instead of my repo because it is now community project. Perhaps, you could have a look the latest codes there and check if there is something wrong compared to your modified codes.

Thank you so much!

jasons2000 commented 7 years ago

if someone had time it would be good if someone could merge all the various useful efforts people have made.

------ Original Message ------ From: "HongKee Moon" notifications@github.com To: "hkmoon/DockFX" DockFX@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Sent: 17/01/2017 09:50:15 Subject: Re: [hkmoon/DockFX] All dockable windows are tabs. Undocked create a window for further docking. (#4)

Hi @alexkoon https://github.com/alexkoon

First of all, I am sorry for my laziness due to current projects. I could not take a look on your code. Today, I had a chance to do that actually.

However, many people are using https://github.com/ClearControl/DockFX instead of my repo because it is now community project. Perhaps, you could have a look the latest codes there and check if there is something wrong compared to your modified codes.

Thank you so much!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hkmoon/DockFX/pull/4#issuecomment-273070955, or mute the thread https://github.com/notifications/unsubscribe-auth/AEBVpMlV_d5orL1efxyvWH1B9T1RMcvpks5rTI7XgaJpZM4LJ-oE.

hkmoon commented 7 years ago

@jasons2000 Someone sounds pointing at me. ;)

alexkoon commented 7 years ago

Thanks - I'll have a look over at the ClearControl branch.

hkmoon commented 7 years ago

@alexkoon Sorry! I actually reverted whole merging process because github had some problems last week. I need more time to check it actually. Thanks!