search

hkparker / go-i2p

A pure Go implementation of the I2P router
MIT License
111 stars 18 forks source link

Implement the datagram specification #11

Open hkparker opened 8 years ago

hkparker commented 8 years ago

documentation

christiaan commented 8 years ago

What implementation do you expect here? Porting the datagram functionality directly from the i2p java code base? Or just some objects that model the specification described in the linked documentation.

What would be nice is some failing tests that show how this feature would be used.

hkparker commented 8 years ago

I start by implementing the models described in the documentation without looking at the Java source, and just write the functionality for reading and parsing the data structures. Many more functions will be needed for these structures of course, but I plan to write them and reference the java/c++ implementations as needed.

For a good example take a look at the KeysAndCert and corresponding tests. The data structure this issue is for actually starts with a KeysAndCert, so the first thing that will be done when reading it is probably call readKeysAndCert on the provided data then process the error and remainder.

Let me know if you'd like some failing tests, but I usually find it easier to write the tests as I write the parsing functions. Also feel free to open an incomplete PR and I'll leave feedback / contribute to it.