hku-mars / BALM

An efficient and consistent bundle adjustment for lidar mapping
GNU General Public License v2.0
700 stars 151 forks source link

Why move a surfel's center by 3 sigma? #44

Open JzHuai0108 opened 1 year ago

JzHuai0108 commented 1 year ago

Dear authors,

I appreciate your great work.

This question arises from the code line

center += 3 * sqrt(eva0) * direct;

To me, this line shifts the center along the minor axis by 3 sigma. The following lines split the voxel into 8 cubes, and check their planarity based on the minimum eigenvalue. All sounds reasonable except for the above line. So why the shift?

Zale-Liu commented 1 year ago

It is our new plane determination method which is not used in this project. More details can be found in "https://arxiv.org/abs/2305.00287".