Closed gregpriday closed 1 year ago
I think we need to remove lock file. Our releases are more stable and no need to keep it, too. I will do it in couple of minutes.
We can rebase the branch to the main. I removed the composer.lock
file.
We need to add some tests. Also, here is the documentation for multiple vector support
Hey guys, need a multiply vector support. Is it working with this realisation?
I am in vacation. I will check again as soon as possible. @Nikcrysis
Hello @gregpriday if you dont have time to finish maybe I can work on this PR. What do you think?
Okay PR rebased and I just push a change for PointsBatch request class. Please pull the changes on your local to test. Ping @gregpriday
Patch coverage: 78.57%
and project coverage change: +0.12%
:tada:
Comparison is base (
8e62cb1
) 87.48% compared to head (cda9f1f
) 87.60%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@hkulekci Great, I'll start working on this again today. I have a few other PRs and suggestions coming too.
Great! I just rebased the branch FYI.
@hkulekci I've added some tests and made a few more changes. I can try to add a few more tests to hit the Codecov requirements.
Is there anything else on my task list for this feature or are we ready to go once I had a few more tests?
In fact, I am grateful for all this contributions. Thanks. I will do a last check after you finish all changes. Just change it as ready for merge whenever it is ready.
Resolves #13
This is still a work in progress. Not happy with it yet, and I still need to write the tests, but putting this up in case you have any comments or would prefer a different direction.
One breaking change I made was using
VectorStructInterface
for the$vector
argument of thePoint
constructor. This makes a lot more sense to me.I've also structured the
MultiVectorStruct
in a way that makes it only compatible with Qdrant 1.2.