search

hkulekci / qdrant-php

Qdrant is a vector similarity engine & vector database. It deploys as an API service providing search for the nearest high-dimensional vectors. With Qdrant, embeddings or neural network encoders can be turned into full-fledged applications for matching, searching, recommending, and much more!
MIT License
93 stars 21 forks source link

Change batch point operations #15

Closed hkulekci closed 1 year ago

hkulekci commented 1 year ago

Somehow, there is a problem with uploading batch points with BatchVectorStruct. For this reason, instead of using PointsBatch, we just start using PointsStruct.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 97.22% and project coverage change: +2.98 :tada:

Comparison is base (d5661c4) 83.33% compared to head (06f6611) 86.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15 +/- ## ============================================ + Coverage 83.33% 86.31% +2.98% - Complexity 237 246 +9 ============================================ Files 53 53 Lines 834 855 +21 ============================================ + Hits 695 738 +43 + Misses 139 117 -22 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `86.31% <97.22%> (+2.98%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/hkulekci/qdrant-php/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0) | Coverage Δ | | |---|---|---| | [src/Models/Request/PointsBatch.php](https://app.codecov.io/gh/hkulekci/qdrant-php/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0#diff-c3JjL01vZGVscy9SZXF1ZXN0L1BvaW50c0JhdGNoLnBocA==) | `96.42% <94.73%> (+96.42%)` | :arrow_up: | | [src/Endpoints/Collections/Points.php](https://app.codecov.io/gh/hkulekci/qdrant-php/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0#diff-c3JjL0VuZHBvaW50cy9Db2xsZWN0aW9ucy9Qb2ludHMucGhw) | `99.00% <100.00%> (+9.90%)` | :arrow_up: | | [src/Models/PointStruct.php](https://app.codecov.io/gh/hkulekci/qdrant-php/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0#diff-c3JjL01vZGVscy9Qb2ludFN0cnVjdC5waHA=) | `100.00% <100.00%> (ø)` | | | [src/Models/Request/CreateCollection.php](https://app.codecov.io/gh/hkulekci/qdrant-php/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0#diff-c3JjL01vZGVscy9SZXF1ZXN0L0NyZWF0ZUNvbGxlY3Rpb24ucGhw) | `100.00% <100.00%> (ø)` | | | [src/Models/VectorStruct.php](https://app.codecov.io/gh/hkulekci/qdrant-php/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0#diff-c3JjL01vZGVscy9WZWN0b3JTdHJ1Y3QucGhw) | `94.44% <100.00%> (+0.69%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

hkulekci commented 1 year ago

Hey @gregpriday could you please review this PR whenever you have time?