search

hkulekci / qdrant-php

Qdrant is a vector similarity engine & vector database. It deploys as an API service providing search for the nearest high-dimensional vectors. With Qdrant, embeddings or neural network encoders can be turned into full-fledged applications for matching, searching, recommending, and much more!
MIT License
93 stars 21 forks source link

Support uuid for Points #28

Closed mbukovy closed 1 year ago

mbukovy commented 1 year ago

Can't we just do this simple thing? It's very limiting to not be able to use uuid.

hkulekci commented 1 year ago

Thanks for contribution! ♥️ Could you add some tests with uuid?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e8e361e) 87.48% compared to head (87245a8) 87.48%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ========================================= Coverage 87.48% 87.48% Complexity 263 263 ========================================= Files 56 56 Lines 903 903 ========================================= Hits 790 790 Misses 113 113 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `87.48% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/hkulekci/qdrant-php/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0) | Coverage Δ | | |---|---|---| | [src/Endpoints/Collections/Points.php](https://app.codecov.io/gh/hkulekci/qdrant-php/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0#diff-c3JjL0VuZHBvaW50cy9Db2xsZWN0aW9ucy9Qb2ludHMucGhw) | `99.00% <100.00%> (ø)` | | | [src/Models/PointStruct.php](https://app.codecov.io/gh/hkulekci/qdrant-php/pull/28?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0#diff-c3JjL01vZGVscy9Qb2ludFN0cnVjdC5waHA=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hkulekci commented 1 year ago

I just pushed some updates to your branch for tests. The tests are already passed without this update but I just want to be sure everything will be okay with sending some uuid as string.

Again. Thanks for your contribution. @mbukovy ❤️