Closed gregpriday closed 10 months ago
Patch coverage: 100.00%
and project coverage change: +0.03%
:tada:
Comparison is base (
f33b689
) 87.60% compared to head (45a2fd6
) 87.64%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello @gregpriday, could we initialize a Helper class or a request factory instead of using a static method inside AbstractEndpoint
? Without changing the AbstractEndpoint
or the client itself, we can use execute()
method of the Client
itself, which is public. What do you think?
Actually, HttpFactory serves this purpose even. Here an example:
$config = new \Qdrant\Config(QDRANT_HOST);
$config->setApiKey(QDRANT_API_KEY);
$client = new Qdrant(new GuzzleClient($config));
# Getting cluster info with custom request
$httpFactory = new \GuzzleHttp\Psr7\HttpFactory();
$request = $httpFactory->createRequest('GET', 'cluster');
$response = $client->execute($request);
var_dump($response);
# Using method for cluster info
var_dump($client->cluster()->info());
Hey @gregpriday I will close this PR. Please update and create a new one if you want to continue working on this topic again and let's discuss it. Thanks for the suggestions here.
As suggested here: https://github.com/hkulekci/qdrant-php/issues/31