search

hkulekci / qdrant-php

Qdrant is a vector similarity engine & vector database. It deploys as an API service providing search for the nearest high-dimensional vectors. With Qdrant, embeddings or neural network encoders can be turned into full-fledged applications for matching, searching, recommending, and much more!
MIT License
93 stars 21 forks source link

OptimizersConfig parameter values could be zero #49

Closed hkulekci closed 8 months ago

hkulekci commented 8 months ago

closes #48

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f458617) 93.75% compared to head (ea162fc) 93.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #49 +/- ## ========================================= Coverage 93.75% 93.75% Complexity 377 377 ========================================= Files 73 73 Lines 1185 1185 ========================================= Hits 1111 1111 Misses 74 74 ``` | [Flag](https://app.codecov.io/gh/hkulekci/qdrant-php/pull/49/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/hkulekci/qdrant-php/pull/49/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0) | `93.75% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Haydar+K%C3%9CLEKC%C4%B0#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hkulekci commented 8 months ago

ping @lukaszknasiecki I am not sure some values could be zero or negative but that validation should be inside the qdrant as well.