search

hkupty / impromptu.nvim

Create prompts fast and easy
MIT License
39 stars 1 forks source link

ask failure #40

Closed KillTheMule closed 5 years ago

KillTheMule commented 5 years ago

Hey, I'm seeing a new error (after not running my tests for some time since stuff was broken)

test/functional/helpers.lua:96: Vim(call):E5108: Error while calling lua chunk for luaeval(): ../../improm ptu.nvim/lua/impromptu/internals/shared.lua:13: Expected 3 arguments

The ask call that's triggering it is here. After looking at shared.lua:13, I kinda suspect that nvim_open_win changed its signature inbetween, but I've not found a corresponding commit. Could you have a look? Thanks!

hkupty commented 5 years ago

Sure! I'll give it a look. I believe the signature has changed Indeed.

hkupty commented 5 years ago

I found the issue. Sorry for taking long, I was on parental leave. I'll push it this evening.

Best regards, Henry

KillTheMule commented 5 years ago

I was on parental leave

Ohh, nice, congratulations then :) Don't worry about taking long, at least not from my side.

hkupty commented 5 years ago

Ohh, nice, congratulations then :)

Thank you very much :)

Don't worry about taking long, at least not from my side.

I've just pushed the fixes. Please check if they work :)

KillTheMule commented 5 years ago

Works nicely, thanks a lot!

hkupty commented 5 years ago

Nice :)