search

hkupty / nvimux

Neovim as a TMUX replacement
Apache License 2.0
445 stars 17 forks source link

vim.tbl_deep_extend is for map-type tables #43

Closed jdelkins closed 2 years ago

jdelkins commented 2 years ago

I'm not quite sure what the plan is in the transition from bootstrap() to setup() but vim.tbl_deep_extend is for map-type tables and the new bindings layout is not that, but rather a list-type table. Accordingly, this works better.

hkupty commented 2 years ago

Thanks for the PR.

The idea of moving to .setup{} is to centralize configuration in a single command rather than a few commands that require a "commit" phase afterwards. It should look more like other newer neovim plugins now, rather than something odd..

Finally, this allows for a rework in the internals simplifying the code, which makes nvimux much simpler, since it should not be very complex anyways.

jdelkins commented 2 years ago

Great, thanks for continuing to maintain the repo! I've been using it for years and love it. Good luck with the modernization

hkupty commented 2 years ago

Thanks! Really glad you like it!