Named args - Githubissues

hkust-taco / mlscript

The MLscript programming language. Functional and object-oriented; structurally typed and sound; with powerful type inference. Soon to have full interop with TypeScript!

https://hkust-taco.github.io/mlscript

MIT License

175 stars 27 forks source link

Named args #174

Closed mbroughani81 closed 1 year ago

mbroughani81 commented 1 year ago

rename the variables used in desugaring.
delete unnecessary logs
add test

NeilKleistGao commented 1 year ago

Before making a formal PR(i.e., non-draft), please:

read the contribution guide
make sure your code passes all regression tests
remove all compilation warning messages and unnecessary debug information

LPTK commented 1 year ago

Seems this PR doesn't yet take into account the change to Fld's definition.

mbroughani81 commented 1 year ago

Seems this PR doesn't yet take into account the change to Fld's definition.

I resolved the suggested changes, and also merge this branch with the current new-definition-typing(on local), to resolve possible conflicts.

LPTK commented 1 year ago

To solve the compilation failures, just use FldFlags.empty instead of FldFlags(false, false).

LPTK commented 1 year ago

I noticed that your latest commits removed some test cases, for example https://github.com/hkust-taco/mlscript/pull/174/commits/84995d033b9a52c196e238b54c0e82697d13c691. There are already very few tests, so please do not make it worse by reducing the coverage further! ;^)