search

hkusu / s3-upload-action

MIT License
18 stars 11 forks source link

Checksum support #16

Open ngmartins-bloqit opened 1 year ago

ngmartins-bloqit commented 1 year ago

Hi there.

It is possible to support enabling checksum on file upload? thanks

ngmartins-bloqit commented 1 year ago

from here:https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html I think it is:

When you're using an SDK, you can set the value of the x-amz-sdk-checksum-algorithm parameter to the algorithm that you want Amazon S3 to use when calculating the checksum. Amazon S3 automatically calculates the checksum value.

ngmartins-bloqit commented 1 year ago

I'm not a NodeJS expert but I think I manage to do the required changes in a separate branch. I also update the documentation on this branch as well.

I would like to push it to you to take a look into it, however, I'm not able to do it so: fatal: unable to access 'https://github.com/hkusu/s3-upload-action.git/': The requested URL returned error: 403

It would be great if you allow me to collaborate with you on this :)

cheers

hkusu commented 1 year ago

Thanks! I will try it at the same time as #20.

hkusu commented 1 year ago

ref: https://github.com/hkusu/s3-upload-action/pull/18