hkzorman / advanced_npc

Advanced NPC for Minetest, using mobs_redo API
Other
17 stars 5 forks source link

character model compatibility #60

Closed BrunoMine closed 6 years ago

BrunoMine commented 6 years ago

I've noticed that the API applies settings in the character.b3d model to work with the model provided by the player_api mod (minetest.0.5.0). Is it possible to create a compatibility to work with minetest 0.4.16?

hkzorman commented 6 years ago

Not sure what are you talking about here. The advanced_npc API does nothing to character.b3d, except use it. The only thing I certainly do is set the collision box. Is this what you are referring to?

BrunoMine commented 6 years ago

probably yes. But if this is too complex you can ignore it.

hkzorman commented 6 years ago

I have been thinking I would like to support this as well, just not sure how. Maybe the version number can help.

Also, I have removed the mob registration from the advanced_npc API. It is up to mods now to register.

I may have an idea what to do, will let you know if it works.

On Fri, Jun 22, 2018 at 6:53 PM BrunoMine notifications@github.com wrote:

probably yes. But if this is too complex you can ignore it.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/hkzorman/advanced_npc/issues/60#issuecomment-399604403, or mute the thread https://github.com/notifications/unsubscribe-auth/AXYPiKvunEqCGfyzw7_l62Rhc5FhfojGks5t_XVkgaJpZM4UyWS0 .

BrunoMine commented 6 years ago

You can use the collision box set by mobs_redo.

BrunoMine commented 6 years ago

For example, my mod sets the collision box to be used in mobs_redo, your API should work based on it.

BrunoMine commented 6 years ago

If you do this, the responsibility for arranging the mesh and its operation will be from the mod that makes the registration.

hkzorman commented 6 years ago

I'm having a hard time finding what you would like me to change. As I said in first comment, the API doesn't registers an entity anymore.

The entity has to be registered by the implementing mod, and hence it has to set a collisionbox.

Is there any particular area of advanced_npc that you would like me to change that you can point out?

BrunoMine commented 6 years ago

OH, Sorry. This really is not related to your API.