search

hl7-be / lab

Creative Commons Zero v1.0 Universal
6 stars 9 forks source link

Visualization of Bundle of Bundles #206

Open bdc-ehealth opened 1 year ago

bdc-ehealth commented 1 year ago

@FrederikVds : https://github.com/ehealthplatformstandards/laboResultVisualization/issues/31

FrederikVds commented 1 year ago

Is this issue limited to visualization or does this also apply to the tests? We have noticed that currently bundles of bundles fail all the tests so we're unpacking them before sending.

bdc-ehealth commented 1 year ago

@FrederikVds, This is also the case for tests. The test server only considers single reports, because it does its work based on the patient id (one patient id per testcase). Do you want to send multiple testcases in one file, or one testcase in one file, but wrapped in an additional bundle?

FrederikVds commented 1 year ago

@bdc-ehealth For reasons of consistency all our outgoing files are collections. If only one testcase can be sent per file, we can send one-file collections though, we don't need the ability to send multiple test cases in a single collection.

FrederikVds commented 1 year ago

Hi @bdc-ehealth

Are there plans to implement receiving collections on the test server?

We're still unpacking all our collections into individual reports before sending them to the test server. This means we're not going through the homologation using the exact same files we're planning to use in production and this is making us a bit nervous.

sttav commented 11 months ago

Hi @bdc-ehealth

what is the status now for bundle in bundles? Has the system the capability to process these collections now?

KR

bdc-ehealth commented 10 months ago

@sttav The bundle of bundles can be used in the visualisation tool now. We can also accept bundles of bundles on the testserver, but sending them is still in development.

bdc-ehealth commented 10 months ago

@FrederikVds see ^^

FrederikVds commented 10 months ago

@bdc-ehealth Thanks. I just tested by sending a bundle of bundles and it works, the documents get handled correctly. One small issue though is that the first line of the XML (<?xml version="1.0" encoding="UTF-8"?>) is treated as an extra document which then obviously fails.

sam-medispring commented 6 months ago

@bdc-ehealth the guidelines don't allow a bundle of bundles ...

https://build.fhir.org/ig/hl7-be/lab/guidance.html#technical-implementation-of-the-specification-published-here

the payload SHALL be an immutable collection according to the 'FHIR Document' paradigm.

--> so payload is a document not a collection ...

bdc-ehealth commented 6 months ago

@sam-medispring ,

the bundle of bundles was an explicit requirement from the labs. I suppose that if the text in the IG should be modified, that will be approved by the HL7 Workgroup without any problems. I will flag this issue to be discussed by the HL7 Workgroup when we start phase 2, as there are a number of other open questions for phase 2.