hl7-be / pss

Prescription Search Support
Other
0 stars 0 forks source link

Examples using PlanDefinition instead of OperationDefinition #39

Closed LionelCremer closed 5 months ago

LionelCremer commented 6 months ago

Here are some examples that require validation and refinement by @bdc-ehealth:

Radiology: Radiology Example Antimicrobial: Antimicrobial Example

In both examples, I have replaced the Operation endpoints with PlanDefinition endpoints. I have included a sequential diagram to compare the two solutions, demonstrating that the payload and response remain the same in both approaches.

bdc-ehealth commented 6 months ago

@LionelCremer

I think we are not allowed to redefine the input of the $apply operation: https://www.hl7.org/fhir/R4/plandefinition-operation-apply.html

Another thing is that I could not find was the .input and .output in ActivityDefinition: https://hl7.org/fhir/R4/activitydefinition.html and I don't see anything that can quickly replace it. So I am not sure yet how the Plandefinition.$apply can produce the resources that are needed.

LionelCremer commented 6 months ago

@bdc-ehealth

  1. You mean that you are not sure that we can request the $apply with a combination of a POST and a specific FHIR resource as payload?
  2. I've updated the ActivityDefinition contents. The output is replaced by "ActivityDefinition.kind" and "ActivityDefinition.profile" and the input is simply removed.

What are the purpose of the "PlanDefinition.action[].input" and "PlanDefinition.action[].output"?

bdc-ehealth commented 6 months ago

@LionelCremer ,

something else I came across: ActivityDefinition.kind cannot be of type #Questionnaire. Only a limited list of resources is allowed: https://hl7.org/fhir/R4/valueset-request-resource-types.html

In the meantime, I applied your other corrections: the result can be seen here: https://build.fhir.org/ig/hl7-be/pss/branches/issue-39

LionelCremer commented 6 months ago

@bdc-ehealth , The branch validates the structure of the resources, but it doesn't validate the transaction between the EPD and PSS server. Right?

bdc-ehealth commented 6 months ago

Yes, indeed, plus I had to put some lines from your example in comment to make it validate. There are certainly still some issues with this proposal.