Closed kridhaen closed 1 year ago
@kridhaen
1) CamelCase is no problem for me (do we go for lowerCamelCase or UpperCamelCase?) 2) The difference between designation and the display-template property is that the designation is a translation/synonym for the code (readable rendering for the code itself), the display-template property that we added is to indicate that it is a template text with placeholders.
I give an example:
concept: inch
code: in
designation nl-BE: duim designation fr: pouce designation en: inch
display template nl-BE: "{0}"" display template fr: "{0} po" display template en: "{0} in"
2a) We will add it to the textual part of the implementation guide. 2b) Yes, all languages are created equally 2c) There is no default language, only the standard description of the code, which is in English. Softwares will be able to choose the language they like from the designations/templates.
Do we want codes to be case sensitive? I would prefer not, and all codes lower case (possibly separated-by-dash)
On Tue, Jan 17, 2023 at 9:23 AM kridhaen @.***> wrote:
- We prefer UpperCamelCase (PascalCase).
— Reply to this email directly, view it on GitHub https://github.com/hl7-be/public-health/issues/26#issuecomment-1385010706, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3HUUFI3RGYBNLBL574EFDWSZJJDANCNFSM6AAAAAATYCXSFE . You are receiving this because you are subscribed to this thread.Message ID: @.***>
@costateixeira I would prefer the codes to be as readable as possible, so lowercase can, but preferably serarated-by-dash or '_'. @bdc-ehealth Here are the proposed codes and translations for EN/nl-BE. I'm still waiting for confirmation from CvKO, so it is possible the translations will change.
WG: we decide to make all codes all uppercase with underscores and case sensitive.
Late in the discussion but for the record:I advise to use the common practice. Underscores are not common (not sure if the FHIR tooling is accepting this, see e.g resource ids cannot have underscore. I'd use dashes as most codes in FHIR. Codes are not meant to be displayed but it's ok that they form words. so lower-case-separated-with-dashes would be my recommendation
In that case, lower-case-separated-with-dashes is also OK for me. We have no real preference, except for it to be case sensitive for simplicity in the used tools for @smals-bvv.
It's ok for Vitalink.
WG: conclusion: lower-case-separated-with-dashes + and @smals-bvv confirms that case-insensitive is also fine.
@bdc-ehealth The Dutch displays and templates will be provided on this issue when I get confirmation from CvKO.