hl7-eu / laboratory

HL7 Europe Laboratory Report HL7 FHIR IG
Creative Commons Zero v1.0 Universal
9 stars 8 forks source link

Clean up the Bundle-BundleHepatitisPanel example #37

Closed gcangioli closed 1 year ago

gcangioli commented 1 year ago

fix errors and warning for the Bundle-BundleHepatitisPanel example

Filename Errors Warnings Hints
Bundle-BundleHepatitisPanel 24 9 22
declankieran-nhsd commented 1 year ago

Hi @gcangioli

I ran the publisher through a debugger and it appears to not like CodeSystem.content being set to example at https://github.com/hl7-eu/laboratory/blob/master/input/fsh/terminologies/lab-localVsCs-lab.fsh#L26

Setting it to complete makes all the errors go away, I see experimental is set to true as well, so it might be an issue with the publisher...

gcangioli commented 1 year ago

thank you @declankieran-nhsd for the indication.

Looking to the definition of the "example" we are not in the case of a "A subset of the valid externally defined concepts are included in the code system resource."

I'll change the setting to "complete" , but I'll leave to @rhausam deciding if to keep it, changing the coded concepts used; or adopting alternative solutions.