hl7au / au-fhir-base

AU Base FHIR Implementation Guide Source
37 stars 26 forks source link

Medication.form - changes to terminology binding are visible in the snapshot only #246

Closed dbojicic-agency closed 5 years ago

dbojicic-agency commented 5 years ago

Brett, changes to add Medication.form binding to Medication Form value set were done and merged into HL7 AU build in Aug 2018; please see https://github.com/hl7au/au-fhir-base/pull/79. However, something seems to have gone wrong with the merge as the changes are not visible in the differential but can be seen in the snapshot (snomedForm slice with required binding to the Medication Form value set). The text summary says that manufacturer is bound to that form set (this was reported in one of the ballot issues).

robeastwood-agency commented 5 years ago

This is due to the parent of Medication.form.coding not being present in the xml immediately prior - Forge at work again (see this line). Ie adding this prior resolves the problem:

<element id="Medication.form">
      <path value="Medication.form"/>
</element>
robeastwood-agency commented 5 years ago

And on closer inspection, the same thing applies to the constraints for Medication.package; they appear in the snapshot but not differential. And adding this before line 520, resolves the problem:

<element id="Medication.package">
      <path value="Medication.package"/>
</element>
robeastwood-agency commented 5 years ago

@oridashi - Brett see PR #249