Incorrect search definition for the Encounter's date

hl7au / au-fhir-core-inferno

This is an Inferno test kit for the AU Core Implementation Guide

https://inferno.hl7.org.au

Apache License 2.0

7 stars 3 forks source link

Incorrect search definition for the Encounter's date #106

Open projkov opened 3 months ago

projkov commented 3 months ago

Initially, the problem was reported by @heathfrankel in this issue https://github.com/hl7au/au-fhir-core-inferno/issues/99

All search tests for the Encounter resource with the search parameter date are failing because there is no data for the search. This is not true, as data definitely exists in the period attribute. The core of the problem is an incorrect search definition for the date parameter. It appears that we are using Encounter.actualPeriod, which is incorrect. Tests should use the Encounter.period path to get the data.

I researched and found that the core of the problem is incorrect search parameters in the search parameters file, which we use to get non-existent search parameter definitions in the IG.

This should be fixed.

StephThaoOng commented 3 months ago

Similar issue found in the below test suites for "search by date" tests:

Immunization
Procedure Suggest re-testing these too when fix is applied. Thanks :)

projkov commented 3 months ago

WIP notes: Encounter -> date is fixed Immunization -> date is fixed Procedure -> date is fixed Organization -> address is fixed

Fixes will be available on production soon...

projkov commented 3 months ago

@StephThaoOng @heathfrankel

AU Core Inferno v0.0.5 has been released.

Fixed search parameters: Encounter, Immunization, Procedure -> date Organization -> address

Please make a retest.

StephThaoOng commented 3 months ago

Confirmed search by date, including for combined parameter searching, for Encounter, Immunization, and Procedure are fixed.
However, multipleAnd search by date, in Encounter and Immunization test suites still return this error:

"diagnostics": "HAPI-1922: Can not have multiple date range parameters for the same param without a qualifier"

Test data is adequate to run these tests. Looking at search by date, it seems the FHIR server may not support this request? i.e. we have to be explicit and include the prefixes? @heathfrankel could you help confirm please? I couldn't find what I was looking for in Smile doco.

Confirmed search by address for Organization is fixed.

projkov commented 3 months ago

Thanks! @StephThaoOng

@heathfrankel If you agree that the search by date is okay now, please move this issue to "Done" or close it.

Regarding the "multipleAnd" problem: If it is an issue on the test suite side, let's create a separate one ticket.

StephThaoOng commented 3 months ago

Hi @projkov

[x] For search by date (test 1.15.03) and search by date+patient (test 1.15.07), can we include tests/requests using data param without comparators. I think the spec requires the server to support a search by date without comparators too.
[ ] For search by date+patient (test 1.15.07), Missing tests for multipleAND search on date param i.e. GET [base]/Encounter?patient={Type/}[id]&date={gt|lt|ge|le}[date]{&date={gt|lt|ge|le}[date]&...}
[ ] For search by date+patient (test 1.15.07), Missing tests using patient.identifier param
[x] For multipleAnd search by date (test 1.15.11), please include date comparators on the search test which will avoid current error being returned "HAPI-1922: Can not have multiple date range parameters for the same param without a qualifier".

version tested: AU Core v0.4.0-ci-build v0.0.6