Changes for aucore-blockvote-9: Encounter

hl7au / au-fhir-core

AU Core FHIR Implementation Guide Source

Other

24 stars 11 forks source link

Changes for aucore-blockvote-9: Encounter #161

Closed dt-r closed 4 months ago

dt-r commented 4 months ago

This PR addresses issues from the AU Core R1 Ballot for Comment aucore-blockvote-9: https://confluence.hl7.org/display/HAFWG/aucore-blockvote-9

Made the following changes to AU Core Encounter:
- removed Must Support from Encounter.identifier FHIR-45212
- removed Must Support from Encounter.type FHIR-44580
- removed Must Support from Encounter.hospitalization, Encounter.hospitalization.dischargeDisposition FHIR-45210
- in Encounter.participant.individual replaced RelatedPerson with AU Base RelatedPerson FHIR-45228
Updated examples to remove elements that are no longer Must Support
Updated change log

brettesler-ext commented 4 months ago

Added use of AU Base Related Person profile for Observation.performer: AU Core Diagnostic Result Observation, Changed AU Core Pathology Result Observation

brettesler-ext commented 4 months ago

Have reviewed @dt-r's changes - can someone review mine?

dbojicic commented 4 months ago

Have reviewed @dt-r's changes - can someone review mine?

I'll do.

dt-r commented 4 months ago

Review comments:

Please update Terminology page to remove resources related to elements that are no longer Must Support

In Must Support - Resource References, replace RelatedPerson with AU Base RelatedPerson.

Fixed both.

dt-r commented 4 months ago

Confirmed above fixes.

Just one minor change - sorry I missed it in the earlier review. Now that Encounter.type is not a MS element, we should remove it from the search parameters (patient+type, type) in both the profile page and the CapabilityStatements.

There is a similar item for dischargeDisposition - the preferred way to handle this is via a Technical Correction (i.e. raise a separate JIRA and track it that way.)

dbojicic commented 4 months ago

https://confluence.hl7.org/display/HAFWG/aucore-blockvote-9

Confirmed above fixes. Just one minor change - sorry I missed it in the earlier review. Now that Encounter.type is not a MS element, we should remove it from the search parameters (patient+type, type) in both the profile page and the CapabilityStatements.

There is a similar item for dischargeDisposition - the preferred way to handle this is via a Technical Correction (i.e. raise a separate JIRA and track it that way.)

Raised https://jira.hl7.org/browse/FHIR-45954.

dbojicic commented 4 months ago

Review comments:

In 2.1.2.2 AU Core Capability Statements, change "a AU Core Requester actor" and "a AU Core Responder actor" to use the correct article "an".