Identifier definition issues across most profiles

[robeastwood-agency]

In discussing an approach for #36 with @brettesler-ext, @jakubsielewicz, @udaychandrupatla and @adp-adha it became apparent that there are a range of issues related to how identifiers are defined across most of the PD profiles. The decision was made to address this clean up first prior to making the changes for #36 - as a separate job lot.

The issues are

AU PD Healthcare Service

• the identifier slice discriminator does not work; should just be pattern:type
• the identifier slice for 'pdvendor' has an inline definition and should be defined in a stand-alone Identifier datatype profile (as has been the pattern in au-fhir-base)
• the pdvendor slice constraints have the wrong CodeSystem for type.coding.system - should be the AU CodeSystem http://terminology.hl7.org.au/CodeSystem/v2-0203
• additionally it was noticed that the definition of the code VDI in the AU Base CodeSystem is incorrect - see ticket https://github.com/hl7au/au-fhir-base/issues/808

AU PD Location

• the identifier element should have must support set to true as per all other PD profiles
• otherwise ok

AU PD Organisation

• the identifier slice discriminator should be pattern:type
• the identifier element should have must support set to true

AU PD Practitioner

• see #34

AU PD Practitioner Role

• the identifier slice discriminator does not work; should just be pattern:type (see #35)
• the identifier slice for 'vendorAssignedDirectoryIdentifier' has an inline definition and should be defined in a stand-alone Identifier datatype profile (as has been the pattern in au-fhir-base) and that this is conceptually the same identifier as the PD Healthcare Service 'pdvendor' identifier
• the inline definition of identifier slice 'vendorAssignedDirectoryIdentifier' has a very relaxed definition such that type, system and value are all optional and this will be addressed by the one shared Identifier datatype profile following the constraints in PD Healthcare Service

AU PD Secure Messaging Endpoint

• the identifier element should have must support set to true
• the identifier slice for 'smdtarget' has an inline definition and should be defined in a stand-alone Identifier datatype profile (as has been the pattern in au-fhir-base); and then this identifier be one of the allowed types
• the identifier slice discriminator should be pattern:type

[robeastwood-agency]

The PR that implements this change #46 has been merged; therefore this issue can be closed.