Closed jgsuess closed 1 month ago
Oh, and w.r.t. there being no ticket, there is a ticket reference in the right margin:
In Jira this is towards https://jira.csiro.au/browse/ST-285
"What do you see in the diff" - I see all the changed files when I select the "Files Changed" tab.
Sounds like I'll have to find some time to go through all these changes to understand how they will affect the master, but I will also need to understand if any of this is still required as I am still not clear what the intended outcome was.
Currently I am focusing on preparing for the connectathon. Perhaps we can discuss on the friday after the connectathon.
I'm closing the pr but keeping the branch that's easiest I think.
Hello @heathfrankel,
First, thank you for making time to review the PR. It is a bit dated, and maybe that is a good reason for dropping it. I have cloned the source code in this branch, so that should not be an issue.
First the intention: My goal was to create an environment that could execute repeatable test runs of the tool in a CI chain. I do not have access to Windows hosts, as they are expensive in licensing. Hence, I needed to run the tool on Linux. I expected that to be easy, as .Net should cross-compile. However, when trying the tool it broke due to what turned out embedded windows path separators. However, this can be fixed by replacing the backslash with a forward slash, which works on both Windows and Unix.
This led me to recompile. The outcome is the file without the extension you have found. In Unix, executables do not have file name extensions. I placed the file in the branch in the way you did with yours, to stay in line with established convention.
Because the build was not automated, I added build automation for Unix and Windows to github actions and archived the results using artifacts.
Now let me have a look at the issues you mentioned:
Please let me know if you want to abandon the MR, as I have said, I only did this to have a basis for my comparison. However, I believe that the automated Github actions build and unix capability may still be of value. In this case, please amend the branch.