search

hl7dk / dk-core

7 stars 6 forks source link

Translations for UCUM should be moved to a CodeSystem #121

Open jkiddo opened 4 months ago

jkiddo commented 4 months ago

https://github.com/hl7dk/dk-core/blob/20c407aa90ddb4d3ba456cd9c93ff6ca2aca44f8/input/fsh/valueSets.fsh#L225

Translations lives in CodeSystems - in this case most likely a CodeSystem fragment and supplement.

jkiddo commented 3 months ago

Relates to https://github.com/hl7dk/dk-core/issues/128

tmsMedcom commented 3 months ago

1) vurder om der er behov at oversætte nogle af koderne (fx percent til procent) og 2) udarbejd et CodeSystem supplement/fragment.

Kirstinerosenbeck commented 3 months ago

In the FHIR datatype Quantity, there is no attribute for a display-term. This is because "code" is just an attribute. Neither the Coding datatype nor the CodableConcept datatype are used. It is when these two datatypes are used, that the code is validated to match display and/or designations, and errors are cast when they do not. In Quantity, this is replaced by a string (attribute unit) without any relation to the code. As such your only option for display is to write a Danish unit here, but it cannot be given beforehand by a CodeSystem fragment and supplement - or if it has - that has no effect on the actual data. I strongly suggest that we drop this.

jkiddo commented 3 months ago

Then the display values should be removed from the valueset