search

hl7dk / dk-core

7 stars 6 forks source link

Introduced IPA support #76

Closed jkiddo closed 4 months ago

jacand commented 9 months ago

The PR is targeting the 2.3.0 branch but you have just merged with master which is now at 3.0.0. I believe you want to re-target this PR

The changes all look fine to me. 4 thoughts, though:

  1. Did we decide in the FHIR SIG / HL7-DK to inherit from the IPA profiles rather than the base FHIR resources? If not, we should bring that question up for a formal decision/vote.
  2. In 3.1.0 the BasicParameter / basic-observation is introduced. I think we should consider aligning that one with IPAObservation. As we haven't got multiple inheritance, some "manual" work would be necessary
  3. All these IPA dependencies should also be reflected in the introductions to each resource profile, and I think we should have a general introduction to IPA and how we use it "somewhere".
  4. We are starting to support FHIR R5 for trial use. Adding IPA would be a good case for "testing" our new process for keeping the revisions aligned. So before merging this PR, I think a matching PR for the R5 branch should be created - cherry picking the changes to that branch as well.