search

hlapp / cc-tools

Tools for Creative Commons licenses
MIT License
3 stars 1 forks source link

Does not support multilanguage sites #2

Open jranke opened 8 years ago

jranke commented 8 years ago

@hlapp: I had a go at adding this over at DandyDev/pelican-bootstrap3#246 but I think for inclusion into your repo this should be polished a bit to be more consistent with your style, which is why I did not create a pull request here.

hlapp commented 7 years ago

@jranke nice work, and many thanks for taking the trouble of posting this over here. I'd welcome a pull request that duplicates the cc-license.html file with multi-language support, and that includes the corresponding message and other files needed at runtime. (I can see the changes to cc-license.html but I don't feel confident determining what needs to go along with it so as to work at runtime.)

Alternatively, a pull request that makes it optional to have multi-language support enabled at runtime.

It took me a couple of steps to figure out how to make the multi-language support work (and thus the whole theme to start with) when I recently upgraded to the latest pelican-bootstrap3 revision (which, as I assume you know, you can't run without multi-language). I would want users to continue to have the option of choosing not to bother at all with the tooling needed for multi-language support.

jranke commented 7 years ago

@hlapp Sorry for the inconvenience with the multilanguage support! Some contributors including me had some discussion how to avoid the need to touch the configuration when the pull request was integrated, but were not able so far to come up with an easier solution. At the moment, I am not active regarding this, but if you adapt cc-license.html to the current pelican-bootstrap3 in a branch, I would be happy to test.