Closed rafasashi closed 1 year ago
Our last plugin submission to the WordPress directory triggered a couple of issues related to sanitizing and escaping values.
The last commit ensure the Template compliance with WordPress coding standards.
Feel free to have a look and drop your observations here.
Thanks for the PR @rafasashi, always nice to see the template improved. I'll do my best to review the changes in the coming week.
You are most welcome Jonathan. Thank you for supporting this boilerplate! As I mentioned to Hugh last time, it is an important part of the integrated workflow we provide to our users.
Hello jonathanbossenger I am following up on this review. Is there anything I could do? If you check the changes we are basically wrapping the raw input/output with sanitize_
and esc_
functions
So sorry @rafasashi March was an extensively busy month for me. Thank you for the reminder.
I have bumped this review up on my to-do list, and I will do my best to review it next week.
@jonathanbossenger any news on this ?
I'm so sorry folks, I've just not had the time to review this. I will try and get it done in the coming weeks.
In some installations
plugin_basename
returns the full path of the plugin file resulting in missing the hookplugin_action_links_{$plugin_file}
I find it safer to use the hook
plugin_action_links
and compare the second argument$file
with the value in$this->parent->file