hlashbrooke / WordPress-Plugin-Template

A robust code template for creating a standards-compliant WordPress plugin.
https://hughlashbrooke.com/
GNU General Public License v2.0
1.03k stars 329 forks source link

WordPress Plugin Directory standards reviewed #101

Closed rafasashi closed 1 year ago

rafasashi commented 1 year ago

In some installations plugin_basename returns the full path of the plugin file resulting in missing the hook plugin_action_links_{$plugin_file}

I find it safer to use the hook plugin_action_links and compare the second argument $file with the value in $this->parent->file

rafasashi commented 1 year ago

Our last plugin submission to the WordPress directory triggered a couple of issues related to sanitizing and escaping values.

The last commit ensure the Template compliance with WordPress coding standards.

Feel free to have a look and drop your observations here.

jonathanbossenger commented 1 year ago

Thanks for the PR @rafasashi, always nice to see the template improved. I'll do my best to review the changes in the coming week.

rafasashi commented 1 year ago

You are most welcome Jonathan. Thank you for supporting this boilerplate! As I mentioned to Hugh last time, it is an important part of the integrated workflow we provide to our users.

rafasashi commented 1 year ago

Hello jonathanbossenger I am following up on this review. Is there anything I could do? If you check the changes we are basically wrapping the raw input/output with sanitize_ and esc_ functions

jonathanbossenger commented 1 year ago

So sorry @rafasashi March was an extensively busy month for me. Thank you for the reminder.

I have bumped this review up on my to-do list, and I will do my best to review it next week.

Lenny4 commented 1 year ago

@jonathanbossenger any news on this ?

jonathanbossenger commented 1 year ago

I'm so sorry folks, I've just not had the time to review this. I will try and get it done in the coming weeks.