Optional Compass/Sass support

hlashbrooke / WordPress-Plugin-Template

A robust code template for creating a standards-compliant WordPress plugin.

https://hughlashbrooke.com/

GNU General Public License v2.0

1.03k stars 329 forks source link

Optional Compass/Sass support #15

Closed yivi closed 5 years ago

yivi commented 10 years ago

I prefer Sass to Less, and use compass to preprocess everything and minify it; so I modified the Gruntfile so it can do so with minimal effort.

The defaul is still less, you just need a change in settings to choose one or the other (Althourh I reckon that once you chose one path or another, you'll just remove the other css preprocessor).

Also added a parameter in the git clone command in "build-plugin", so it brings as little history as possible before rm-fing ".git".

Regards!

hlashbrooke commented 10 years ago

@kloon If you have a moment to look at this, let me know if it will fit in with the existing code without breaking the Less support. No rush :)

kloon commented 10 years ago

Looks good to me @hlashbrooke, you will just need to change the variable depending on which preprocessor you want to use, it defaults to less so should not break anything.

hlashbrooke commented 10 years ago

Thanks @kloon.

@yivi I'm happy with to add this in, but there are two changes that you've made that need to be modified before I can merge this PR:

You renamed and moved assets/css/frontend.css to assets/css/scss/admin.scss - I'm not quite sure why, but we still need to keen the frontend.css file in there, so please revert that change.
You added a new folder & file (assets/css/scss/config.rb) - this will need to be accounted for in the build-plugin.sh script. Best bet would be to add an option for it and remove the files if they're not needed.

Let me know what you think.

yivi commented 10 years ago

I had removed the "compiled" css files while testing and forgot about them. Readded them in place.

Added support in the builder script so users can decide if they want compass/less/none; removing files and updating Gruntfile accordingly.

Plus added a blank .gitignore if we want a new repository, adding things pertinent to Grunt or Compass if they are enabled.

yivi commented 10 years ago

Also added a "add_metaboxes" that receives an hash and calls "add_metabox" accordingly.

yivi commented 10 years ago

Any plans on merging all this? :) Mostly to keep me from having to merging back new commits from the master branch.

Regards!

hlashbrooke commented 10 years ago

Hi Ivan,

Thanks for following up on this - sorry for the delay, but I just haven't had time to give this a real test yet. I've been super busy lately and not sure when I'll have time to do a full test, but I promise to look at it soon!

yivi commented 10 years ago

Ok, no worries.

I'm just finishing up another feature: Support for repeating fields in the AdminApi. I needed to have it for a project I'm working with, so I hope to back port it to a branch in my fork early next week.

Regards!

hlashbrooke commented 9 years ago

Hi Ivan,

It's been a while, but if you're still keen to have this merged then please have a look at the conflicts that have cropped up since I merged some other PRs recently and let me know if you can work through them easily. The conflicts shouldn't be anything too intense to work out :)

jonathanbossenger commented 6 years ago

Hi @yivi I know it's been a while since this PR, but are you able to fix the conflicts, so that we can look into merging this in? Thanks

grappler commented 6 years ago

Compass is no longer actively maintained. https://github.com/Compass/compass

It would be better to have some type of grunt or gulp or even a simple node script for this.

jonathanbossenger commented 5 years ago

I have not heard from the original requester, so I am closing this PR