search

hlashbrooke / WordPress-Plugin-Template

A robust code template for creating a standards-compliant WordPress plugin.
https://hughlashbrooke.com/
GNU General Public License v2.0
1.03k stars 329 forks source link

Include possibility to customize options prefix #86

Closed alantygel closed 4 years ago

alantygel commented 5 years ago

Wordpress uses a prefix to identify the options stored for each plugin. This PR creates the option of customizing this prefix in the build plugin bash script.

jonathanbossenger commented 4 years ago

@alantygel before this PR can be considered, could I ask you to please fix the conflicts.

Thanks

jonathanbossenger commented 4 years ago

@alantygel sorry to do this, first off thanks for the updated PR.

However it seems that @e-baker's PR #89 makes some changes which yours will overwrite, you may need to rebase your develop branch with the latest develop branch from this repo to make sure you get the latest changes, and ensure your PR doesn't overwrite anything merged into develop this morning.

Thanks

cornelRaiu commented 4 years ago

@jonathanbossenger it seems that the merge commit overrode the changes in PR #89 . Can you please check that? Let me know if I should make another PR for the issue.

jonathanbossenger commented 4 years ago

@cornelRaiu sorry about that mate, please do create another PR and I'll get it merged in. Thanks