hlaueriksson / GEmojiSharp

:octocat: GitHub Emoji for C#, ASP.NET Core and Blazor, dotnet tool for the terminal and PowerToys Run plugin
https://hlaueriksson.github.io/GEmojiSharp/
MIT License
116 stars 8 forks source link

:beetle: not rendering due to bad raw #6

Closed timheuer closed 3 years ago

timheuer commented 3 years ago

The :beetle: is not rendering correctly

hlaueriksson commented 3 years ago

Hi @timheuer

I think that the current raw :beetle: emoji is correct, even though it looks broken on some systems. It is taken from https://github.com/github/gemoji/blob/master/db/emoji.json#L7899 And it is the same as https://emojipedia.org/beetle/

It looks broken on Windows 10 and some other operating system I tested with. On Android 11, it looks good to me:

Screenshot_20201121-140729

hlaueriksson commented 3 years ago

However, it looks like GitHub mixed up the rendering of :beetle: and :lady_beetle:

https://github.com/hlaueriksson/github-emoji#user-content-beetle

image

:lady_beetle: should look like https://emojipedia.org/lady-beetle/

hlaueriksson commented 3 years ago

@timheuer do you think posting an issue about this in https://github.com/github/g-emoji-element is the the right way forward?

timheuer commented 3 years ago

If you look at https://emojipedia.org/lady-beetle/ definition and the Shortcodes section it indicates

:beetle: (Github, Slack)
hlaueriksson commented 3 years ago

I found issues with two other emojis:

:man_in_tuxedo: 🤵‍♂️ != 🤵
:bride_with_veil: 👰‍♀️ != 👰
hlaueriksson commented 3 years ago

The :beetle: emoji is fixed in version 1.4.0 of GEmojiSharp: https://www.nuget.org/packages/GEmojiSharp/1.4.0

@timheuer Thanks for the pull request!

hlaueriksson commented 2 years ago

Hi again @timheuer

It looks like GitHub changed the rendering of the :beetle: emoji.

I wanted to give you a heads up that on the upcoming version 1.5.0 of GEmojiSharp, you need to use the :lady_beetle: emoji to render a :lady_beetle:.