search

hldb / welo

peer-to-peer, collaborative states using Merkle-CRDTs
Other
32 stars 2 forks source link

fix: replace broken bloom filter #115

Closed saul-jb closed 6 months ago

saul-jb commented 6 months ago

This PR fixes #113 by replacing the bloom filter with a slimmed down implementation that fixes the stack overflow error.

tabcat commented 6 months ago

what is the bloom filter code for again? is this all being tested correctly?

saul-jb commented 6 months ago

what is the bloom filter code for? is this all being tested correctly?

The bloom filter was for the heads set reconciliation between peers. There are probably better ways of doing this but the bloom filter was a good start.

There are no tests for the filter itself yet, I'll add some soon.

saul-jb commented 6 months ago

Tests added - I think it should be good to go.