hldouglas / dsn1674-assignment-3

Typography and Planets
0 stars 0 forks source link

Fine tuning typography aesthetics #1

Open hldouglas opened 9 years ago

hldouglas commented 9 years ago
hldouglas commented 9 years ago

@thomasjbradley

thomasjbradley commented 9 years ago

For the quotes:

Inside the blockquote instead of using q, because blockquote is already a quote, change the tag to a p tag. Then put actual quote marks into the p tag. If you surround the quote with an element, like a span you can style them separately.

<p><span>“</span>...

For the <dl>:

The dl has two different elements inside it in the HTML—pick one of the two and apply bold only to it.


For different lists:

You probably want to use a class="" attribute on one of them, giving it a name, so you can style it separately. https://github.com/algonquindesign/html-css/tree/gh-pages/using-css#naming-and-classes


p.s. In the future, it's much easier for me to manage if each question is a separate issue on GitHub.

hldouglas commented 9 years ago

Everything worked except the bolding of the dt element in dl I've been attempting to make dt have it's own properties (didn't work) and create a class for dt (also didn't work)

thomasjbradley commented 9 years ago

This line here is still bolding all of the dl: https://github.com/hldouglas/dsn1674-assignment-3/blob/gh-pages/css/main.css#L48

hldouglas commented 9 years ago

Deleted an no change.

thomasjbradley commented 9 years ago

Typo: font-weight, not font-style.