search

hlissner / evil-multiedit

Multiple cursors for evil-mode, based on iedit
MIT License
345 stars 11 forks source link

evil-mulitedit broken with recent iedit changes #39

Closed CeleritasCelery closed 2 years ago

CeleritasCelery commented 4 years ago

A recent commit to iedit breaks evil-multiedit--substitute and evil-multiedit--paste-replace. I was able to bisect the offending commit down to https://github.com/victorhge/iedit/commit/be44da7e2196895dadb28e3013ec1733d853cd97. It is a pretty large commit so I was not able to find out what actually causes the regression.

CeleritasCelery commented 4 years ago

FYI @victorhge

hlissner commented 4 years ago

This is a known issue that I am working on a fix for. For the time being I've pinned iedit to 77eb0a1e2e44b453e4ebf4c38409affa353f5139 in Doom Emacs. If you aren't using Doom you'll have to do similar for now.

ema2159 commented 4 years ago

Is this what's causing this behavior?:

ezgif-6-b07b6f1e9648

hlissner commented 4 years ago

@ema2159 Yes

srnnkls commented 3 years ago

Any news on this?

ericdallo commented 2 years ago

lsp-mode introduced a new feature using iedit and some functions that are not available on older iedit versions :/ It'd be really cool fix this issue to bump iedit on doom-emacs

ericdallo commented 2 years ago

c/c @hlissner

hlissner commented 2 years ago

Sorry for the late response. As of a451370 evil-multiedit should work fine with the latest commit of iedit, so I'll consider this issue resolved. Let me know if that isn't the case and I'll reopen it.

@ericdallo Thanks for letting me know! I'll bump Doom's module soon. Also, sorry to spring this on you: 36904ce introduced a breaking change I've been sitting on for some time; lsp-evil-multiedit-highlights and lsp-evil-multiedit-linked-ranges will need to be updated:

-  (evil-multiedit-state))
+  (evil-multiedit-mode +1))

My access to a dev machine is unstable so it'll be a couple days before I can PR it myself, so feel free to snipe it if you'd like.

ericdallo commented 2 years ago

Great! I'll make the proper changes on lsp-mode, thank you for the huge help on this!

ericdallo commented 2 years ago

Fixed on lsp-mode