evil-snipe-scope 'buffer not respected

[maciekk]

What did you expect to happen?

When I have evil-snipe-scope set to 'buffer and I do "s xx", I expect all hits of "xx" to highlight, and to be able to step through all of the hits in the buffer.

What actually happened?

What happens: my ability to walk through hits appears to be limited to just 'visible, even though I know there are more hits further down. Hitting 's' on last visible hit says "Can't find xx" which is incorrect. Incidentally, if initial hit is NOT on screen, then "s xx" will scroll down to first hit, but once again is not able to find further matches further down in buffer.

Describe your attempts to resolve the issue

Double-checked that C-h v evil-snipe-scope does show 'buffer, and hasn't been somehow temporarily set to 'visible in that buffer. Doing so confirms it is actually set to 'buffer, as desired.

Steps to reproduce

• open large (multi-screen) text file
• place some unique letter pairs (e.g., "xx") throughout file, including at very end (ensures last hit being off-screen)
• go to start of file
• make sure window is not large enough to show the whole file/buffer
• search for the magic pair: "s xx"
• walk through hits by continuing to hit "s"
• note how last found hit is on the same visible screen, and no attempt to scroll to end of file was performed

Package commit

1a28d718c835a21591a170af78a03a366cd60c0d

System Information

Using DOOM Emacs (synced relatively recently, probably about 1-2 months ago), with evil-snipe pinned to 1a28d718c835a21591a170af78a03a366cd60c0d (DOOM default). Running on recent/latest MacOS, GNU Emacs 27.1

[maciekk]

Sigh, Murphy's law, of course as soon as I post bug and start looking further, I just happen to spot more variables that make clear what's going on: there is a separate variable for snipe repeats (evil-snipe-repeat-scope). Everything works as expected now.