search

hlissner / ws-butler

Unobtrusively trim extraneous white-space *ONLY* in lines edited.
7 stars 3 forks source link

Maintainership #6

Open Apteryks opened 2 hours ago

Apteryks commented 2 hours ago

What would you like to know?

Hi,

I'm a bit confused by ws-butler's current maintainership. It seems you claim to be the maintainer, while the original project is still used by most distributions/MELPA, and contributions merged here are not forwarded there.

Could you please clarify why this fork is necessary, and who should use it?

Apteryks commented 2 hours ago

For info, in the meantime, I've forwarded the accumulated commits in this repo to the original upstream: https://github.com/lewang/ws-butler/pull/53

Thanks for authoring/merging these useful bits.

hlissner commented 1 hour ago

It seems you claim to be the maintainer

I do? I don't recall doing so. This fork was created to address this issue, which upstream later reverted, so I continued maintaining this privately solely for Doom Emacs (plus, at the time, it didn't seem like the upstream package was maintained), but I'm not interested in taking over general maintainership for this package.

However, I recently abandoned it, and it's been sitting around since, so I should probably archive it.

Anyhow, feel free to PR it upstream if you like the changes, but I'd suggest you omit https://github.com/lewang/ws-butler/pull/53/commits/2bb49d3ee7d2cba133bc7e9cdac416cd1c5e4fe0 (as not to undo https://github.com/lewang/ws-butler/pull/37).

EDIT: I think these commits should be removed too:

Apteryks commented 52 minutes ago

@hlissner Thanks a lot for the feedback, I have a better grasp of the situation now. I've dropped the commits you mention, and updated the PR accordingly. Let me know if something else should be adjusted. Thanks!