search

hlmod / Shop-Core

Documentation
https://hlmod.github.io/Shop-Core/module/create/
GNU General Public License v3.0
28 stars 26 forks source link

Fast double map change corrupt internal structure of shop data #107

Open Kailo97 opened 3 years ago

Kailo97 commented 3 years ago

Describe the bug this bug requires testing and confirmation Fast double map change corrupt internal structure of shop data. Sourcemod error logs start to spam

L 07/26/2021 - 21:51:01: [SM] Exception reported: Invalid Handle c710bab (error: 1)
L 07/26/2021 - 21:51:01: [SM] Blaming: shop/shop.smx
L 07/26/2021 - 21:51:01: [SM] Call stack trace:
L 07/26/2021 - 21:51:01: [SM]   [0] ArrayList.FindValue
L 07/26/2021 - 21:51:01: [SM]   [1] Line 659, addons/sourcemod/scripting/shop/item_manager.sp::ItemManager_OnItemRegistered

I looked at action SM log and found that in time of error starts spam map was changed twice in 2-4 seconds.

L 07/26/2021 - 21:51:00: -------- Mapchange to de_mirage --------
L 07/26/2021 - 21:51:02: -------- Mapchange to de_mirage --------

Full logs with two exmples here: (12:02:10 and 21:51:00) errors_20210726.log L20210726.log

To Reproduce Steps to reproduce the behavior:

  1. Change map once
  2. Change map again in next 2-4 seconds
  3. See error

Expected behavior No errors =)

Server (please complete the following information):