search

hlolli / csound-mode

Emacs major mode for coding in Csound
41 stars 14 forks source link

Can not play sound by csound-play #25

Closed sohet closed 1 year ago

sohet commented 1 year ago

From the last update, I can not play sound out of box by csound-play (C-c C-p). If there is a need to remove "-odac" from the function, I think setting the default value of csound-play-flags to "-odac" in csound-mode.el is preferable. Without it csound-play only makes a test sound file for a starter.

hlolli commented 1 year ago

Yes, you are correct. I think this will prove to be problematic, rather I should make this configureable for those who want to customize their play script. I didn't pay much attention to that part of the PR, my apologies.

hlolli commented 1 year ago

I made what I feel is a proper solution, the default value of csound-play-flags is set to -odac so when a user changes it, they can make csound do whatever they want.

rubenphilipp commented 1 year ago

Yes, you are correct. I think this will prove to be problematic, rather I should make this configureable for those who want to customize their play script. I didn't pay much attention to that part of the PR, my apologies.

Hey y'all,

I have to concede that this is apparently my, and not Hlöðver's, fault, as I -- in my pull request -- have changed the respective line (for obvious reasons, as pointed out in https://github.com/hlolli/csound-mode/issues/25#issuecomment-1567234711) without proper documentation. Anyway, I am glad we have got a proper solution now.

Greetings Ruben

sohet commented 1 year ago

Thank you Hlöðver for the quick fix, and thank you Ruben for the nice additions!