hlolli / csound-mode

Emacs major mode for coding in Csound
41 stars 14 forks source link

sintax highlight and indentation #9

Open davigega opened 4 years ago

davigega commented 4 years ago

Hello! I'm new to emacs and I decided to use your package to work with csound. I manage to install the csound-mode from Melpa and the compilation is working great (even the guide in the mini buffer, which I found great!), but the text highlight and indentation features are not. Any suggestion?

hlolli commented 4 years ago

Could you send me your output from M-x describe-mode

for me I have

Enabled minor modes: Aggressive-Indent Auto-Composition
Auto-Compression Auto-Encryption Column-Number Company Dimmer
Display-Time Eldoc Electric-Indent Eval-Sexp-Fu-Flash File-Name-Shadow
Flx-Ido Font-Lock Global-Aggressive-Indent Global-Auto-Revert
Global-Company Global-Eldoc Global-Font-Lock Global-Hl-Line
Global-Undo-Tree Ido-Everywhere Ido-Vertical Line-Number Mode-Icons
Mouse-Wheel Override-Global Projectile Recentf Savehist Shell-Dirtrack
Show-Paren Size-Indication Tabbar Tabbar-Mwheel Tooltip Transient-Mark
Undo-Tree Which-Key Xclip Yas Yas-Global

(Information about these minor modes follows the major mode info.)

Csound Mode mode defined in ‘csound-mode.el’:
A major mode for interacting and coding Csound

but for the indentation, it could depend how you set up indentation globally, some users bind it to TAB, most bind newline (enter) to newline-and-indent, I personally use agsressive-indent-mode.

burnedmonk commented 4 years ago

I really appreciate this project. .I have the same problem. it doesn't even work with eldoc. what are the necessary packages? thank you very much

hlolli commented 4 years ago

If you've installed it via melpa, it should all work out of the box automatically. I guess I did something wrong. Could you help me solve this by sending me the version of csound-mode which you're using and the result of M-x describe-mode while you have a csound file opened?

If there's no syntax highlighting, it could mean that font-lock-mode is disabled. If eldoc doesn't work, it probably means that eldoc-mode is off. But both should be on by default.

davigega commented 4 years ago

sorry for the late answer: csound-mode version: 20191005.80

describe-mode

Enabled minor modes: Auto-Composition Auto-Compression Auto-Encryption
Autopair Autopair-Global Blink-Cursor Eldoc Electric-Indent
File-Name-Shadow Font-Lock Global-Auto-Complete Global-Eldoc
Global-Font-Lock Global-Linum Line-Number Linum Menu-Bar Mouse-Wheel
Pyvenv Shell-Dirtrack Show-Paren Tool-Bar Tooltip Transient-Mark

I also checked the font-lock-mode is enable by using: M-x font-lock-mode twice. The first one returns Font-Lock mode disable in current buffer and the second time it enables it again

burnedmonk commented 4 years ago

I try on a fresh install in emacs for OS X and linux csound-mode ver 20191005.807

describe-mode

Enabled minor modes: Auto-Composition Auto-Compression Auto-Encryption
Blink-Cursor Eldoc Electric-Indent File-Name-Shadow Font-Lock
Global-Eldoc Global-Font-Lock Line-Number Menu-Bar Mouse-Wheel
Tool-Bar Tooltip Transient-Mark

I activate debug-on-error on my .emacs file

Debugger entered--Lisp error: (void-function first)
  first(("ares oscils iamp, icps, iphs [, iflg]"))
  csound-eldoc-template-lookup((#("asig" 0 4 (fontified t)) #("oscils" 0 6 (fontified t)) #(".7" 0 2 (fontified t)) #("220" 0 3 (fontified t)) #("0" 0 1 (fontified t)) #("iflg" 0 4 (fontified t))))
  csound-eldoc-function()
  eldoc-print-current-symbol-info()
  #f(compiled-function () #<bytecode 0x400f18cf>)()
  apply(#f(compiled-function () #<bytecode 0x400f18cf>) nil)
  timer-event-handler([t 0 0 500000 nil #f(compiled-function () #<bytecode 0x400f18cf>) nil idle 0])

thank you very much and sorry for my little eng

hlolli commented 4 years ago

@burnedmonk thank so much for this good catch!

I pushed a fix https://github.com/hlolli/csound-mode/commit/ba4a5ddcc9140f036714e82c5d378e61a4cbfe19 for this right away. For some reson, first was renamed to cl-first some time ago, it's not the first time I'm having these kinds of problems with the cl-lib.

I will research the other problems later on soon. I'm working on a better testing environment to help me catch these mistakes earlier.

burnedmonk commented 4 years ago

Now eldoc works great!

JoVide commented 3 years ago

Hi! After trying on and off for a few month to get the syntax highlighting to work I just discovered that I've been installing csound-mode through melpa-stable (version 0.2.1, I think) instead of melpa. The melpa-stable version works, except for the syntax highlighting. Now I've installed it through melpa and everything so far works perfectly!

I just wanted to drop this here if someone else has the same issue. I love the work that's been done on this mode and I hope to learn more elisp to hopefully be able to contribute in the future.

jave commented 1 year ago

Hi! After trying on and off for a few month to get the syntax highlighting to work I just discovered that I've been installing csound-mode through melpa-stable (version 0.2.1, I think) instead of melpa. The melpa-stable version works, except for the syntax highlighting. Now I've installed it through melpa and everything so far works perfectly!

I just wanted to drop this here if someone else has the same issue. I love the work that's been done on this mode and I hope to learn more elisp to hopefully be able to contribute in the future.

thanks, this helped me as well!

michaelmariaott commented 1 year ago

For me the syntax highlighting stopped working, after installing the company mode. Reinstalling csound-mode or uninstalling company-mode does not help. It was otherwise a clean Emacs installation (Windows 11).

Enabled minor modes: Auto-Composition Auto-Compression Auto-Encryption
Blink-Cursor Company Eldoc Electric-Indent File-Name-Shadow Font-Lock
Global-Eldoc Global-Font-Lock Indent-Tabs Line-Number Menu-Bar
Mouse-Wheel Show-Paren Tool-Bar Tooltip Transient-Mark
interperipheral commented 1 year ago

I am having this issue as well on Windows 10. The syntax highlighting works fine on first install of the package but stops working permanently after restart. Enabled minor modes: Auto-Composition Auto-Compression Auto-Encryption Blink-Cursor Column-Number Company Company-Quickhelp Company-Quickhelp-Local Delete-Selection Eldoc Electric-Indent File-Name-Shadow Font-Lock Global-Auto-Revert Global-Company Global-Eldoc Global-Font-Lock Global-Hl-Line Indent-Tabs Line-Number Menu-Bar Mouse-Wheel Shell-Dirtrack Show-Paren Tooltip Transient-Mark Windmove

hlolli commented 1 year ago

I think it may be related to the fact that hl-mode has been deprecated for a better solution. I haven't looked deep into this. Im thinking because I'm missing "highlight" there in the minor modes, I'll look into this and update!

PvonN commented 1 year ago

For me the syntax highlighting works not quite well. Its highlighting paths and comments but nothing else. How should it look like?

describe-mode: Enabled minor modes: Auto-Composition Auto-Compression Auto-Encryption Auto-Fill Blink-Cursor Column-Number Corfu Eldoc Electric-Indent File-Name-Shadow Font-Lock Global-Corfu Global-Eldoc Global-Font-Lock Global-Nlinum Line-Number Marginalia Menu-Bar Mouse-Wheel Nlinum Override-Global Savehist Show-Paren Text-Scale Tooltip Transient-Mark Vertico

sohet commented 1 year ago

How about adding the following line to the emacs initialization file as written at https://github.com/hlolli/csound-mode/issues/10#issuecomment-593794583 ? (with-eval-after-load 'csound-font-lock (setq csound-font-lock-list csound-font-lock-keywords))

interperipheral commented 1 year ago

Seemed to solve things for me, thank you!

On Wed, Apr 19, 2023 at 8:43 AM sohet @.***> wrote:

How about adding the following line to the emacs initialization file as written at #10 (comment) https://github.com/hlolli/csound-mode/issues/10#issuecomment-593794583 ? (with-eval-after-load 'csound-font-lock (setq csound-font-lock-list csound-font-lock-keywords))

— Reply to this email directly, view it on GitHub https://github.com/hlolli/csound-mode/issues/9#issuecomment-1514586743, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANH5V6X3NDPEU2JGPI3AUWTXB7FVZANCNFSM4JGJMOSA . You are receiving this because you commented.Message ID: @.***>