hlorenzi / customasm

💻 An assembler for custom, user-defined instruction sets! https://hlorenzi.github.io/customasm/web/
Apache License 2.0
704 stars 55 forks source link

Major build upgrade and minor feature upgrades #151

Closed JosephAbbey closed 2 years ago

JosephAbbey commented 2 years ago

I have changed the build process to asyncronousely build all platforms (windows, linux, web, web-portable) then publish to github-pages and github releases. You will no longer need a ghpages branch as I make use of the new "Deploy GitHub Pages site" action (https://github.com/marketplace/actions/deploy-github-pages-site).

I also added the "Hex Line by Line" (1 instruction of hex per line) and the "Bin Line by Line" (1 instruction of binary per line) formats.

I have made it possible for the linux version to run on CentOS 7 (which many old build servers still run).

I have generated a portable (1 file, no internet) version of the web build.

I have made the line references in the error output link to the line in the code.

hlorenzi commented 2 years ago

I appreciate your contribution and initiative in tackling so many issues!

Unfortunately, I can't accept this pull request as is. There are too many changes to review at once. Also, I've noticed a few issues:

I would like to kindly ask you to submit each new feature as its own pull request, if possible! Ideally, one pull request for each of the following changes (usually with one commit each):

That way I would be able to understand better what kinds of changes I'd be bringing into the repository. Do you think you can start by opening a new pull request for the new build targets alone?

JosephAbbey commented 2 years ago

Sure thing,

I will create a new fork with one commit per change and after all the commits one tag for a minor version bump.

JosephAbbey commented 2 years ago

I have now created a new pull request with the discussed changes. #152.