search

hlorenzi / kmp-editor

Intuitive Mario Kart Wii course data editor!
21 stars 8 forks source link

fix issue#3 Store GOBJ: Extended presence flags #8

Open ch-mcl opened 2 years ago

ch-mcl commented 2 years ago

these changes "Copy" column of "Values for padding" to ✔(means supporting). https://wiki.tockdom.com/wiki/Extended_presence_flags/Software_Overview#KMP_Tools

Wiimm claims KMP editing tools "must store padding of GOBJ section values". https://wiki.tockdom.com/wiki/Extended_presence_flags/Implementation_Hints#Reference-Id_.28Padding.29 It's means this tool must store "ExtraData" of "GOBJ".

thus I changed store ExtraDatas of GOBJ. and I expand it to any sections(KTPT, ENPT, ENPH etc...) ExtraData. It's for other sections expand in the future.

ch-mcl commented 2 years ago

If you only hope fix issue #3 . needs add these lines.

https://github.com/hlorenzi/kmp-editor/blob/98bd2491abaf8e01b38af2371ba058a445a8c969/src/util/kmpData.js#L70 https://github.com/hlorenzi/kmp-editor/blob/98bd2491abaf8e01b38af2371ba058a445a8c969/src/util/kmpData.js#L306 https://github.com/hlorenzi/kmp-editor/blob/98bd2491abaf8e01b38af2371ba058a445a8c969/src/util/kmpData.js#L328 https://github.com/hlorenzi/kmp-editor/blob/98bd2491abaf8e01b38af2371ba058a445a8c969/src/util/kmpData.js#L872 https://github.com/hlorenzi/kmp-editor/blob/98bd2491abaf8e01b38af2371ba058a445a8c969/src/util/kmpData.js#L875-L876 https://github.com/hlorenzi/kmp-editor/blob/98bd2491abaf8e01b38af2371ba058a445a8c969/src/util/kmpData.js#L1252

I extend it as any sections(KTPT, ENPT, ENPH etc...). It's for other sections extends in the future.

tbh, idk other section expand happens actually ... I suppose it's happen. this is why I expand it.